[Intel-gfx] [PATCH] drm/i915: Disable all GEM timers and work on unload

Daniel Vetter daniel at ffwll.ch
Fri Oct 11 18:22:55 CEST 2013

On Fri, Oct 11, 2013 at 11:14 AM, Chris Wilson <chris at chris-wilson.co.uk> wrote:
>  void
> @@ -4711,11 +4707,9 @@ i915_gem_lastclose(struct drm_device *dev)
>         if (drm_core_check_feature(dev, DRIVER_MODESET))
>                 return;
> -       mutex_lock(&dev->struct_mutex);
> -       ret = i915_gem_idle(dev);
> +       ret = i915_gem_idle(dev, false);

I think this here should also set disable=true, in case X died
prematurely and forgot to do the leavevt dance. At that point I think
we could rip out that disable parameter again and just set it when in
ums mode. Also this change should be in a separate patch, at least I
don't understand why we need to change it here together with the
untangling of the gpu_idle/gem_idle confusion.
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch

More information about the Intel-gfx mailing list