[Intel-gfx] [PATCH v5 0/4] Fix Win8 backlight issue

Igor Gnatenko i.gnatenko.brain at gmail.com
Fri Oct 11 23:01:36 CEST 2013


On Fri, 2013-10-11 at 12:42 -0400, Josh Boyer wrote:
> On Fri, Oct 11, 2013 at 9:27 AM, Aaron Lu <aaron.lu at intel.com> wrote:
> > v5:
> > 1 Introduce video.use_native_backlight module parameter and set its
> >   value to false by default as suggested by Rafael. For Win8 systems
> >   which have broken ACPI video backlight control, the parameter can be
> >   set to 1 in kernel cmdline to skip registering ACPI video's backlight
> >   interface. Due to this change, the acpi_video_verify_backlight_support
> >   is moved from video_detect.c to video.c - patch 3/4;
> 
> That's a fairly untenable position for distro kernels to be in.  They
> now have to ask every user that reports an issue with the backlight to
> try setting that option on the command line.  While I appreciate the
> setting breaks things for some people, doesn't the Win8 issue impact
> far more people?  Shouldn't it be defaulted to true?
> 
> If nothing else, can you add a config option for the default so
> distros can use that to decide which way to default it and then work
> on fixing the remaining users that have troubles?
> 
> josh

I think more better to use this unregister as default and give option to
disable it.

-- 
Igor Gnatenko
Fedora release 20 (Heisenbug)
Linux 3.11.4-301.fc20.x86_64




More information about the Intel-gfx mailing list