[Intel-gfx] [PATCH] drm/i915: make backlight functions take a connector v4

Jesse Barnes jbarnes at virtuousgeek.org
Sat Oct 12 00:44:05 CEST 2013

On Fri, 11 Oct 2013 14:46:36 -0700
Jesse Barnes <jbarnes at virtuousgeek.org> wrote:

> On VLV/BYT, backlight controls a per-pipe, so when adjusting the
> backlight we need to pass the correct info.  So make the externally
> visible backlight functions take a connector argument, which can be used
> internally to figure out the pipe backlight to adjust.
> v2: make connector pipe lookup check for NULL crtc (Jani)
>     fixup connector check in ASLE code (Jani)
> v3: make sure we take the mode config lock around lookups (Daniel)
> v4: fix double unlock in panel_get_brightness (Daniel)

Ok ok you caught me.  I didn't test v3...  I did test this version but
w/o lockdep and apparently w/o any ASLE events or I would have seen the
sleeping while atomic messages.

Guess we'll have to factor out the ASLE callback into a work queue (I
don't *think* the BIOS will care, we'll have to see).

Jesse Barnes, Intel Open Source Technology Center

More information about the Intel-gfx mailing list