[Intel-gfx] [PATCH] drm/i915: Clamp cursor coordinates to int16_t range

Daniel Vetter daniel at ffwll.ch
Mon Oct 21 18:15:06 CEST 2013


On Mon, Oct 21, 2013 at 6:01 PM,  <ville.syrjala at linux.intel.com> wrote:
> From: Ville Syrjälä <ville.syrjala at linux.intel.com>
>
> We store cursor_x/y as int16_t internally, but the user provided
> coordinates are int32_t. Clamp the coordinates so that they don't
> overflow the int16_t. Since the cursor is only 64x64 in size, the
> clamping can't cause any visual changes.
>
> Signed-off-by: Ville Syrjälä <ville.syrjala at linux.intel.com>


For shits&giggles: You've bothered with a subtest for this in your crc
cursor test? Should be a one-liner and would neatly test whether QA
catches it ...
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch



More information about the Intel-gfx mailing list