[Intel-gfx] [PATCH 1/2] drm/i915: Abstract backlight registers a bit

Daniel Vetter daniel at ffwll.ch
Tue Oct 22 00:30:11 CEST 2013

On Mon, Oct 21, 2013 at 7:35 PM, Ben Widawsky
<benjamin.widawsky at intel.com> wrote:
> Many GENs generally perform the same actions just on different
> registers. This is true going forward as well. To ease the transition a
> bit, extract the common code where possible.
> Signed-off-by: Ben Widawsky <ben at bwidawsk.net>

Imo we should just switch to vtables or something like that, since
it's not just the register that changes, but also the meaning of the
different bits in the registers themselves and the logic to drive
stuff. We've often had regression-galore in this code and strictly
separating different platforms should help. I hope.
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch

More information about the Intel-gfx mailing list