[Intel-gfx] [PATCH] lib/drmtest: Scream harder when igt_exit isn't called for subtest tests

Daniel Vetter daniel.vetter at ffwll.ch
Tue Oct 29 11:35:10 CET 2013


We really need this since otherwise the magic return value handling
for running testcases with piglit (or on QA's validation
infrastructure) doesn't work properly.

We need to be careful though to only install this check on success.

See also the previous commits to sprinkle igt_exit() calls over all
the tests that missed it.

Signed-off-by: Daniel Vetter <daniel.vetter at ffwll.ch>
---
 lib/drmtest.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/lib/drmtest.c b/lib/drmtest.c
index 8164ef9..576b4ab 100644
--- a/lib/drmtest.c
+++ b/lib/drmtest.c
@@ -812,8 +812,6 @@ int igt_subtest_init_parse_opts(int argc, char **argv,
 		case 'l':
 			if (!run_single_subtest)
 				list_subtests = true;
-			else
-				igt_install_exit_handler(check_igt_exit);
 			break;
 		case 'r':
 			if (!list_subtests)
@@ -842,6 +840,8 @@ int igt_subtest_init_parse_opts(int argc, char **argv,
 		}
 	}
 
+	igt_install_exit_handler(check_igt_exit);
+
 out:
 	return ret;
 }
-- 
1.8.1.4




More information about the Intel-gfx mailing list