[Intel-gfx] [PATCH] drm/i915: Fix cursor visibility checks also for the right/bottom screen edges

Chris Wilson chris at chris-wilson.co.uk
Tue Sep 3 10:13:47 CEST 2013


On Tue, Sep 03, 2013 at 11:04:30AM +0300, ville.syrjala at linux.intel.com wrote:
> From: Ville Syrjälä <ville.syrjala at linux.intel.com>
> 
> First of all we should not be looking at fb->{width,height} as those do
> not tell us what the actual pipe size is. Second of all we need to use
> >= for the comparison.
> 
> So fix the comparison, and make use of the new pipe_src_{w,h} to
> determine the real pipe source dimensions.
> 
> Signed-off-by: Ville Syrjälä <ville.syrjala at linux.intel.com>

Whoops.

Reviewed-by: Chris Wilson <chris at chris-wilson.co.uk>

And r-b for its sibling as well. I am pretty sure there are real-world
bugs out there, but they are going to pretty be rare and the same user
is never likely to see it twice... And just maybe more recent hw isn't
quite so hang-happy!
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre



More information about the Intel-gfx mailing list