[Intel-gfx] [PATCH v2] drm/i915/hsw: Add display Audio codec disable sequence for Haswell

[Daniel Vetter]

On Fri, Aug 30, 2013 at 1:50 AM,  <mengdong.lin at intel.com> wrote:
> +       /* Wait for 2 vertical blanks */
> +       intel_wait_for_vblank(dev, pipe);
> +       intel_wait_for_vblank(dev, pipe);
> +
> +       /* Disable audio PD. This is optional as per Bspec.  */
> +       temp = I915_READ(HSW_AUD_PIN_ELD_CP_VLD);
> +       temp &= ~(AUDIO_OUTPUT_ENABLE_A << (pipe * 4));
> +       I915_WRITE(HSW_AUD_PIN_ELD_CP_VLD, temp);

If this is optional do we really need the two vblank waits above?
Adding them just for fun when we generally try to rip out as many
vblank waits as possible from the modeset code isn't all that great
...

Also I'd really like to see the audio stuff being tracked in the pipe
config instead of splattering these different ad-hoc state bits like
intel_crtc->eld_vld all over the place.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch