[Intel-gfx] [PATCH] drm/i915: Remove unused mode_fixup() vfunc of struct intel_dvo_dev_ops

[Daniel Vetter]

On Thu, Sep 05, 2013 at 06:52:07PM +0100, Damien Lespiau wrote:
> It's totally unused, so remove the last mode_fixup appearance in i915.
> 
> Signed-off-by: Damien Lespiau <damien.lespiau at intel.com>

Yeah! Queued for -next, thanks for the patch.
-Daniel
> ---
>  drivers/gpu/drm/i915/dvo.h        | 11 -----------
>  drivers/gpu/drm/i915/intel_dvo.c  |  5 -----
>  drivers/gpu/drm/i915/intel_sdvo.c |  3 ---
>  3 files changed, 19 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/dvo.h b/drivers/gpu/drm/i915/dvo.h
> index 33a62ad..3121633 100644
> --- a/drivers/gpu/drm/i915/dvo.h
> +++ b/drivers/gpu/drm/i915/dvo.h
> @@ -77,17 +77,6 @@ struct intel_dvo_dev_ops {
>  			  struct drm_display_mode *mode);
>  
>  	/*
> -	 * Callback to adjust the mode to be set in the CRTC.
> -	 *
> -	 * This allows an output to adjust the clock or even the entire set of
> -	 * timings, which is used for panels with fixed timings or for
> -	 * buses with clock limitations.
> -	 */
> -	bool (*mode_fixup)(struct intel_dvo_device *dvo,
> -			   const struct drm_display_mode *mode,
> -			   struct drm_display_mode *adjusted_mode);
> -
> -	/*
>  	 * Callback for preparing mode changes on an output
>  	 */
>  	void (*prepare)(struct intel_dvo_device *dvo);
> diff --git a/drivers/gpu/drm/i915/intel_dvo.c b/drivers/gpu/drm/i915/intel_dvo.c
> index 406303b..ef5c12a 100644
> --- a/drivers/gpu/drm/i915/intel_dvo.c
> +++ b/drivers/gpu/drm/i915/intel_dvo.c
> @@ -265,11 +265,6 @@ static bool intel_dvo_compute_config(struct intel_encoder *encoder,
>  #undef C
>  	}
>  
> -	if (intel_dvo->dev.dev_ops->mode_fixup)
> -		return intel_dvo->dev.dev_ops->mode_fixup(&intel_dvo->dev,
> -							  &pipe_config->requested_mode,
> -							  adjusted_mode);
> -
>  	return true;
>  }
>  
> diff --git a/drivers/gpu/drm/i915/intel_sdvo.c b/drivers/gpu/drm/i915/intel_sdvo.c
> index 317e058..9fc5dd2 100644
> --- a/drivers/gpu/drm/i915/intel_sdvo.c
> +++ b/drivers/gpu/drm/i915/intel_sdvo.c
> @@ -1209,9 +1209,6 @@ static void intel_sdvo_mode_set(struct intel_encoder *intel_encoder)
>  	    !intel_sdvo_set_tv_format(intel_sdvo))
>  		return;
>  
> -	/* We have tried to get input timing in mode_fixup, and filled into
> -	 * adjusted_mode.
> -	 */
>  	intel_sdvo_get_dtd_from_mode(&input_dtd, adjusted_mode);
>  	if (intel_sdvo->is_tv || intel_sdvo->is_lvds)
>  		input_dtd.part2.sdvo_flags = intel_sdvo->dtd_sdvo_flags;
> -- 
> 1.8.3.1
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch