[Intel-gfx] [PATCH] drm/i915: garbage-collect vlv refclk function

Damien Lespiau damien.lespiau at intel.com
Mon Sep 16 12:41:16 CEST 2013


On Mon, Sep 16, 2013 at 11:29:34AM +0200, Daniel Vetter wrote:
> Simply inline the 100MHz default we're using. Having gunk around that
> has leftover LVDS support on a platform that just doesn't have this
> isn't of any use.
> 
> Signed-off-by: Daniel Vetter <daniel.vetter at ffwll.ch>

Reviewed-by: Damien Lespiau <damien.lespiau at intel.com>

-- 
Damien

> ---
>  drivers/gpu/drm/i915/intel_display.c | 24 +-----------------------
>  1 file changed, 1 insertion(+), 23 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
> index 2e74ccc..fb04f3d 100644
> --- a/drivers/gpu/drm/i915/intel_display.c
> +++ b/drivers/gpu/drm/i915/intel_display.c
> @@ -4288,28 +4288,6 @@ static inline bool intel_panel_use_ssc(struct drm_i915_private *dev_priv)
>  		&& !(dev_priv->quirks & QUIRK_LVDS_SSC_DISABLE);
>  }
>  
> -static int vlv_get_refclk(struct drm_crtc *crtc)
> -{
> -	struct drm_device *dev = crtc->dev;
> -	struct drm_i915_private *dev_priv = dev->dev_private;
> -	int refclk = 27000; /* for DP & HDMI */
> -
> -	return 100000; /* only one validated so far */
> -
> -	if (intel_pipe_has_type(crtc, INTEL_OUTPUT_ANALOG)) {
> -		refclk = 96000;
> -	} else if (intel_pipe_has_type(crtc, INTEL_OUTPUT_LVDS)) {
> -		if (intel_panel_use_ssc(dev_priv))
> -			refclk = 100000;
> -		else
> -			refclk = 96000;
> -	} else if (intel_pipe_has_type(crtc, INTEL_OUTPUT_EDP)) {
> -		refclk = 100000;
> -	}
> -
> -	return refclk;
> -}
> -
>  static int i9xx_get_refclk(struct drm_crtc *crtc, int num_connectors)
>  {
>  	struct drm_device *dev = crtc->dev;
> @@ -4317,7 +4295,7 @@ static int i9xx_get_refclk(struct drm_crtc *crtc, int num_connectors)
>  	int refclk;
>  
>  	if (IS_VALLEYVIEW(dev)) {
> -		refclk = vlv_get_refclk(crtc);
> +		refclk = 100000;
>  	} else if (intel_pipe_has_type(crtc, INTEL_OUTPUT_LVDS) &&
>  	    intel_panel_use_ssc(dev_priv) && num_connectors < 2) {
>  		refclk = dev_priv->vbt.lvds_ssc_freq * 1000;
> -- 
> 1.8.4.rc3
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx



More information about the Intel-gfx mailing list