[Intel-gfx] [PATCH] overlay: fix link error due to missing -lrt

Damien Lespiau damien.lespiau at intel.com
Tue Sep 17 01:23:13 CEST 2013


On Mon, Sep 16, 2013 at 11:47:43PM +0200, Julien Cristau wrote:
> On Mon, Sep 16, 2013 at 15:48:18 -0300, Rodrigo Vivi wrote:
> 
> > CC: Damien Lespiau <damien.lespiau at intel.com>
> > Signed-off-by: Rodrigo Vivi <rodrigo.vivi at gmail.com>
> > ---
> >  overlay/Makefile.am | 2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/overlay/Makefile.am b/overlay/Makefile.am
> > index 426a3df..c648875 100644
> > --- a/overlay/Makefile.am
> > +++ b/overlay/Makefile.am
> > @@ -65,4 +65,6 @@ intel_gpu_overlay_SOURCES += \
> >  
> >  intel_gpu_overlay_SOURCES += $(both_x11_sources)
> >  
> > +intel_gpu_overlay_LDADD = $(LDADD) -lrt
> > +
> >  EXTRA_DIST=README
> 
> Assuming this is about clock_gettime (which really the commit message
> should say), there should be a configure check.  Recent libc doesn't
> need it.

Indeed. Always adding -lrt works but is, of course, not perfect. Note
that we have other unconditional linking against librt already that
could be audited.

One could steal what glib does and define a special CLOCK_GETTIME_LIBS
variable that will end up either empty or equal to '-lrt':

https://git.gnome.org/browse/glib/tree/configure.ac#n2414

-- 
Damien



More information about the Intel-gfx mailing list