[Intel-gfx] [PATCH] uxa: Do not change DPMS mode on unconnected outputs

Rodrigo Vivi rodrigo.vivi at gmail.com
Fri Sep 20 12:56:40 CEST 2013


"The operation is in theory redundant, and in the case of Haswell where
we have multiple outputs aliasing to the same encoder, actually harmful."

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=68030
Credits-to: Chris Wilson <chris at chris-wilson.co.uk>
Tested-by: Rodrigo Vivi <rodrigo.vivi at gmail.com>
Signed-off-by: Rodrigo Vivi <rodrigo.vivi at gmail.com>
---
 src/uxa/intel_display.c | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/src/uxa/intel_display.c b/src/uxa/intel_display.c
index 7dc0f68..0cb63b3 100644
--- a/src/uxa/intel_display.c
+++ b/src/uxa/intel_display.c
@@ -1123,10 +1123,11 @@ intel_output_dpms(xf86OutputPtr output, int dpms)
 				intel_output_dpms_backlight(output,
 							    intel_output->dpms_mode,
 							    dpms);
-			drmModeConnectorSetProperty(mode->fd,
-						    intel_output->output_id,
-						    props->prop_id,
-						    dpms);
+			if (output->crtc)
+				drmModeConnectorSetProperty(mode->fd,
+							    intel_output->output_id,
+							    props->prop_id,
+							    dpms);
 			if (dpms != DPMSModeOff)
 				intel_output_dpms_backlight(output,
 							    intel_output->dpms_mode,
-- 
1.8.1.4




More information about the Intel-gfx mailing list