[Intel-gfx] [PATCH 11/11] drm/i915: Drop explicit plane restoration during resume

Daniel Vetter daniel at ffwll.ch
Sat Sep 21 14:50:29 CEST 2013


On Fri, Sep 20, 2013 at 03:21:03PM -0300, Paulo Zanoni wrote:
> 2013/9/20 Paulo Zanoni <przanoni at gmail.com>:
> > 2013/9/20 Ville Syrjälä <ville.syrjala at linux.intel.com>:
> >> On Thu, Sep 19, 2013 at 07:24:19PM -0300, Paulo Zanoni wrote:
> >>> 2013/9/16  <ville.syrjala at linux.intel.com>:
> >>> > From: Ville Syrjälä <ville.syrjala at linux.intel.com>
> >>> >
> >>> > We already restore planes during the modeset operation, so no need to do
> >>> > another loop over the planes and try to restore them again.
> >>>
> >>> What about the call from intel_lid_notify()? It helps if you explain
> >>> on the commit message why/how we already restore things.
> >>
> >> Sorry, I figured it's more or less obvious:
> >>
> >> for each crtc
> >>  -> __intel_set_mode
> >>    -> .crtc_enable
> >>      -> intel_enable_planes
> >>        -> for each plane on crtc
> >>          -> intel_plane_restore
> >
> > But that still doesn't explain the case where intel_lid_notify calls
> > setup_hw_state directly.
> > Perhaps maybe I'm just confused.
> 
> Yeah, I was totally confused.
> 
> Now that you resent patch 6, for patches 6-11: Reviewed-by: Paulo
> Zanoni <paulo.r.zanoni at intel.com>

Merged them all, thanks for patches&review.

> (Daniel will have to rebase some things)

wiggle took care of everything ;-)

Cheers, Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch



More information about the Intel-gfx mailing list