[Intel-gfx] [PATCH v2] drm/i915/hsw: Add display Audio codec disable sequence for Haswell

Daniel Vetter daniel at ffwll.ch
Mon Sep 23 10:57:13 CEST 2013


On Mon, Sep 23, 2013 at 10:52 AM, Lin, Mengdong <mengdong.lin at intel.com> wrote:
>> Also I'd really like to see the audio stuff being tracked in the pipe config instead
>> of splattering these different ad-hoc state bits like intel_crtc->eld_vld all over
>> the place.
>> -Daniel
>
> How about adding a flag "has_audio" to intel_crtc->config?
> If okay, I'll write a patch to clean up checking on intel_crtc->eld_vld here and there.

That's actually my plan: HDMI/DP encoders should set config->has_audio
in their ->compute_config if we have audio enabled, and everything
else should then just check intel_crtc->config.has_audio. If you do
the patch for hsw I'll volunteer to convert older platforms.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch



More information about the Intel-gfx mailing list