[Intel-gfx] [PATCH] drm/i915: Mask LPSP to get PSR working even with Power Well in use by audio.

Rodrigo Vivi rodrigo.vivi at gmail.com
Wed Sep 25 22:59:03 CEST 2013


Hi Daniel,

Please consider to accept this for -fixes, otherwise PSR will never
work on Haswell on 3.12.

Thanks,
Rodrigo.

On Wed, Sep 25, 2013 at 5:51 PM, Rodrigo Vivi <rodrigo.vivi at gmail.com> wrote:
> Power Well in use forces constantly PSR to exit.
> On recent Kernel I noticed that PSR Performance Counter was always 0
> indicating that PSR was never really achieved.
> By masking LPSP, PSR can work normally and save power on Haswell.
>
> Signed-off-by: Rodrigo Vivi <rodrigo.vivi at gmail.com>
> ---
>  drivers/gpu/drm/i915/intel_dp.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
> index 79c14e2..2c555f9 100644
> --- a/drivers/gpu/drm/i915/intel_dp.c
> +++ b/drivers/gpu/drm/i915/intel_dp.c
> @@ -1467,7 +1467,7 @@ static void intel_edp_psr_setup(struct intel_dp *intel_dp)
>
>         /* Avoid continuous PSR exit by masking memup and hpd */
>         I915_WRITE(EDP_PSR_DEBUG_CTL, EDP_PSR_DEBUG_MASK_MEMUP |
> -                  EDP_PSR_DEBUG_MASK_HPD);
> +                  EDP_PSR_DEBUG_MASK_HPD | EDP_PSR_DEBUG_MASK_LPSP);
>
>         intel_dp->psr_setup_done = true;
>  }
> --
> 1.7.11.7
>



-- 
Rodrigo Vivi
Blog: http://blog.vivi.eng.br



More information about the Intel-gfx mailing list