[Intel-gfx] [PATCH] drm/i915: Restore global mappings upon resume

Chris Wilson chris at chris-wilson.co.uk
Thu Sep 26 22:08:12 CEST 2013


On Thu, Sep 26, 2013 at 09:38:41AM -0700, Ben Widawsky wrote:
> On Thu, Sep 26, 2013 at 05:16:53PM +0100, Chris Wilson wrote:
> > On Thu, Sep 26, 2013 at 09:04:53AM -0700, Ben Widawsky wrote:
> > > On Thu, Sep 26, 2013 at 09:22:45AM +0100, Chris Wilson wrote:
> > > > +		obj->has_global_gtt_mapping = false;
> > > > +		obj->has_aliasing_ppgtt_mapping = false;
> > > 
> > > Actually, the aliasing PPGTT mapping may very well still be in tact.
> > > Unless I'm not seeing something that you are.
> > 
> > I was about to agree with you, but we zap the PDEs in the clear_range()
> > above and don't otherwise restore them, so it looks like without that
> > optimisation we need to clear the ppgtt flag as well.
> > -Chris
> > 
> 
> Having trouble finding it on the interwebs. Please see:
> 1375315222-4785-15-git-send-email-ben at bwidawsk.net

Right, that will allow us to skip the per-object reload of the
aliasing_ppgtt PTE.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre



More information about the Intel-gfx mailing list