[Intel-gfx] intel_pre_enable_dp
Jesse Barnes
jbarnes at virtuousgeek.org
Mon Sep 30 02:16:58 CEST 2013
On Mon, 30 Sep 2013 01:53:47 +0200
Andi Kleen <andi at firstfloor.org> wrote:
> On Mon, Sep 30, 2013 at 01:48:13AM +0200, Andi Kleen wrote:
> >
> > Jesse,
> >
> > I was playing with a static analyzer and it flagged the following
> > code of yours.
> >
> > Is the val = 0 directly after the register read correct and intended?
>
> Also the same pattern is in other places, like vlv_pre_enable_dp.
Hm definitely looks suspect... I'll check it out. On the plus side
that code is actually working in practice, so maybe the zeroing isn't
too harmful. :)
--
Jesse Barnes, Intel Open Source Technology Center
More information about the Intel-gfx
mailing list