[Intel-gfx] [PATCH 2/2] drm/i915/vlv: use per-pipe backlight controls

Daniel Vetter daniel at ffwll.ch
Mon Sep 30 13:25:04 CEST 2013


On Mon, Sep 30, 2013 at 10:33 AM, Jani Nikula
<jani.nikula at linux.intel.com> wrote:
> Anyway, I think you need to add per pipe save/restore to
> i915_save_display/i915_restore_display too.

I'm trying (very slowly at that) to move the register save/restore
stuff out of there into more suitable places. Either we should now
what should go in there (like all the w/a bits we set in e.g.
init_clock_gating) or we need to have an appropriate place to store it
more localized to all the other relevant code/data.

People simply forget about save/restore_display when enabling new
platforms or fixing up stuff since it's somewhere completely else.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch



More information about the Intel-gfx mailing list