[Intel-gfx] [PATCH] drm/i915: Fix the computation of required fb size for pipe

Daniel Vetter daniel at ffwll.ch
Wed Apr 2 09:10:44 CEST 2014


On Wed, Apr 02, 2014 at 07:58:18AM +0100, Chris Wilson wrote:
> On Thu, Mar 20, 2014 at 03:11:21PM +0000, Chris Wilson wrote:
> > The computation of required framebuffer size in
> > 
> > commit d978ef14456a38034f6c0e94a794129501f89200
> > Author: Jesse Barnes <jbarnes at virtuousgeek.org>
> > Date:   Fri Mar 7 08:57:51 2014 -0800
> > 
> >     drm/i915: Wrap the preallocated BIOS framebuffer and preserve for KMS fbcon v12
> > 
> > is too optimistic, and would rely on the invariant fb being
> > reconstructed to exactly fit each pipe (and probably ignore hardware
> > limits). Instead, we want to compute the upper bound on what the display
> > engine will access and ensure that is within the inherited framebuffer.
> > 
> > Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
> > Cc: Jesse Barnes <jbarnes at virtuousgeek.org>
> 
> Ping. The code is just waiting to explode.

I kinda hoped it would magically get reviewed by Jesse. Thanks for the
ping, patch is picked up for -fixes.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch



More information about the Intel-gfx mailing list