[Intel-gfx] [PATCH i-g-t 5/7] kms_cursor_crc: Add reference software rendering

Ville Syrjälä ville.syrjala at linux.intel.com
Wed Apr 2 13:21:59 CEST 2014


On Wed, Apr 02, 2014 at 02:06:28PM +0300, Antti Koskipaa wrote:
<snip>
> @@ -184,9 +192,6 @@ static void test_crc_offscreen(test_data_t *test_data)
>  	do_test(test_data, left - (cursor_w+512), right + (cursor_w+512), top                 , bottom                 );
>  	do_test(test_data, left                 , right                 , top - (cursor_h+512), bottom + (cursor_h+512));
>  	do_test(test_data, left - (cursor_w+512), right + (cursor_w+512), top - (cursor_h+512), bottom + (cursor_h+512));
> -
> -	/* go nuts */
> -	do_test(test_data, INT_MIN, INT_MAX, INT_MIN, INT_MAX);

Why are you dropping the go nuts test? We had an actual bug in the
driver that this managed to hit. We should keep this test to avoid
regressions.

-- 
Ville Syrjälä
Intel OTC



More information about the Intel-gfx mailing list