[Intel-gfx] [PATCH 3/6] drm/i915: Preserve ring buffers objects across resume

[Chris Wilson]

On Wed, Apr 02, 2014 at 03:10:13PM -0700, Jesse Barnes wrote:
> On Wed,  2 Apr 2014 16:36:08 +0100
> Chris Wilson <chris at chris-wilson.co.uk> wrote:
> 
> > +static void
> > +i915_gem_stop_ringbuffers(struct drm_device *dev)
> > +{
> > +	struct drm_i915_private *dev_priv = dev->dev_private;
> > +	struct intel_ring_buffer *ring;
> > +	int i;
> > +
> > +	for_each_ring(ring, dev_priv, i)
> > +		intel_cleanup_ring_buffer(ring);
> > +}
> > +
> 
> You've improved the init/alloc ringbuffer naming, but this one
> confuses me.  stop_ringbuffers to me says we're just idling them, but
> cleanup_ring_buffer actually does the unmap and free right?
> 
> If so, it looks like this will still tear things down on suspend?
> 
> Maybe it's all the refactoring making me miss it. :)

No, something went wrong in the rebase... stop_ringbuffers(dev) is meant to
call foreach(ring) stop_ring_buffer(ring).
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre