[Intel-gfx] [PATCH 3/4] drm/i915: enable HDMI mode on VLV when an HDMI sink is detected

Ville Syrjälä ville.syrjala at linux.intel.com
Thu Apr 3 12:30:26 CEST 2014


On Wed, Apr 02, 2014 at 10:08:53AM -0700, Jesse Barnes wrote:
> Allows sending of the null packets for conformance.

Just set it for all platforms? I'm not aware of any downside of setting
it always.

Anyways seems sane enough so even for just VLV:
Reviewed-by: Ville Syrjälä <ville.syrjala at linux.intel.com>

> 
> Signed-off-by: Jesse Barnes <jbarnes at virtuousgeek.org>
> ---
>  drivers/gpu/drm/i915/intel_hdmi.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/intel_hdmi.c b/drivers/gpu/drm/i915/intel_hdmi.c
> index 3b804fc..fb9839b 100644
> --- a/drivers/gpu/drm/i915/intel_hdmi.c
> +++ b/drivers/gpu/drm/i915/intel_hdmi.c
> @@ -650,8 +650,8 @@ static void intel_hdmi_mode_set(struct intel_encoder *encoder)
>  	else
>  		hdmi_val |= SDVO_COLOR_FORMAT_8bpc;
>  
> -	/* Required on CPT */
> -	if (intel_hdmi->has_hdmi_sink && HAS_PCH_CPT(dev))
> +	if (intel_hdmi->has_hdmi_sink &&
> +	    (HAS_PCH_CPT(dev) || IS_VALLEYVIEW(dev)))
>  		hdmi_val |= HDMI_MODE_SELECT_HDMI;
>  
>  	if (intel_hdmi->has_audio) {
> -- 
> 1.7.9.5
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Ville Syrjälä
Intel OTC



More information about the Intel-gfx mailing list