[Intel-gfx] [PATCH 2/6] drm/i915: dma_buf_vunmap is presumed not to fail, don't let it

Daniel Vetter daniel at ffwll.ch
Wed Apr 9 15:03:33 CEST 2014


On Mon, Apr 07, 2014 at 05:01:47PM -0300, Rodrigo Vivi wrote:
> From: Chris Wilson <chris at chris-wilson.co.uk>
> 
> Since dma_buf_vunmap() procedes blithely on ignorant of whether the
> driver failed to actually unmap the backing storage for the dma-buf, we
> need to make a best-effort to do so. This involves not allowing
> ourselves to be susceptible to signals causing us to leak the storage.
> 
> This should have been detectable with the current i-g-t as a misplaced
> signal should have left the pages pinned upon freeing the object where
> we have a warning in place.

Apparently QA is asleep, or have I missed the bugzilla?
> 
> Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
> Signed-off-by: Rodrigo Vivi <rodrigo.vivi at gmail.com>

Queued for -next, thanks for the patch.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch



More information about the Intel-gfx mailing list