[Intel-gfx] [PATCH] drm/i915: add flags to i915_ring_stop

[Daniel Vetter]

On Fri, Mar 28, 2014 at 05:04:25PM +0000, Chris Wilson wrote:
> On Fri, Mar 28, 2014 at 06:18:18PM +0200, Mika Kuoppala wrote:
> > Piglit runner and QA are both looking at the dmesg for
> > DRM_ERRORs with test cases. Add a flag to control those
> > when we they are expected from related test cases.
> > 
> > Also add flag to control if contexts should be banned
> > that introduced the hang. Hangcheck is timer based and
> > preventing bans by adding sleeps to testcases makes
> > testing slower.
> > 
> > v2: intel_ring_stopped(), readable comment (Chris)
> > v3: keep compatibility (Daniel)
> 
> Do we really want to keep backwards compatibility with the igt testsuite
> that currently fails through debugfs?

I'm leaning towards keeping things working if it's not too much fuzz.
Yeah, currently igt is a bit botched, but with this negative flag you can
still run older igt on newer kernels and the other way round, withing
limits of things simply being broken.

>  
> > References: https://bugs.freedesktop.org/show_bug.cgi?id=75876
> > Signed-off-by: Mika Kuoppala <mika.kuoppala at intel.com>
> 
> However, it is not a battle worth fighting, so either way,
> Reviewed-by: Chris Wilson <chris at chris-wilson.co.uk>

Sorry that I've missed this, please ping me next time around there's a
patch ready to be picked up. Merged to dinq, thanks.

Please push the relevant igt patches, last time I've looked the interfaces
and docs and all that looked excellent.

Cheers, Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch