[Intel-gfx] [PATCH] load_cursor_argb is supposed to return a Bool, not void

Julien Cristau jcristau at debian.org
Mon Apr 14 20:35:54 CEST 2014


On Mon, Apr 14, 2014 at 11:22:03 -0700, Keith Packard wrote:

> By mis-declaring this function, we ended up using software cursors
> because the value seen by the caller was 0.
> 
> Signed-off-by: Keith Packard <keithp at keithp.com>
> ---
>  src/sna/sna_display.c      | 8 ++++++--
>  src/sna/sna_display_fake.c | 3 ++-
>  src/uxa/intel_display.c    | 7 +++++--
>  3 files changed, 13 insertions(+), 5 deletions(-)
> 
Only since
http://cgit.freedesktop.org/xorg/xserver/commit/?id=901fbfbbbd71c0d82080957f8ba09eebbc786f2b

Which could probably have used a different name to avoid silent
breakage.

Cheers,
Julien



More information about the Intel-gfx mailing list