[Intel-gfx] [PATCH 2/2] drm/i915: Move plane enabling to the end of ilk_crtc_enable

Daniel Vetter daniel.vetter at ffwll.ch
Tue Apr 15 22:56:55 CEST 2014


On Tue, Apr 15, 2014 at 10:05 PM, Ville Syrjälä
<ville.syrjala at linux.intel.com> wrote:
> This more or less duplicates what's in my watermark series already. Except
> you have a few more bugs here. The intel_wait_for_vblank() should be after
> the plane enabling since it's a hack to avoid the flip done interrupts
> getting mixed up. Also intel_update_fbc() must happen after enabling the
> planes. I also made the enable and disable symmetric whereas you didn't.
>
> Dunno maybe you just want to grab the patch from my series?

Which one would that be? I just frobbed things sufficiently until the
warning from enable_primary_hw_plane disappeared ;-) But yeah fbc
should be enabled afterwards for sure.

I'm really looking forward to the brave new world where we bring up
the pipe in a fashionable black and then do a nuclear flip.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch



More information about the Intel-gfx mailing list