[Intel-gfx] [PATCH 1/2] drm/i915: Only break encoder linked when linked to connector

Egbert Eich eich at freedesktop.org
Wed Apr 16 08:04:38 CEST 2014


Daniel Vetter writes:
 > 
 > Hm, I think to address Chris' concern we should split this into two
 > pieces: connector_break_all links which only breaks connector->encoder
 > stuff, used in both places as is. And a new encoder_break_all links which
 > we'll use in sanitize_crtc in a new encoder loop.

I've got a different solution, although it requires a bit more 
code: Instead of having a single break_all_links() function I 
move the  link breaking code into the two functions where it 
is used (ie sanitize_encoder() and sanitize_crtc()).
This gives one a bit more flexibility in implementing what is 
needed and makes the code a bit clearer.
I will send later - once I had the opportunity to test.

Cheers,
	Egbert.



More information about the Intel-gfx mailing list