[Intel-gfx] [PATCH 5/5] drm/i915: Move buffer pinning and ring selection to intel_crtc_page_flip()

[Chris Wilson]

On Tue, Apr 15, 2014 at 09:41:38PM +0300, ville.syrjala at linux.intel.com wrote:
> From: Ville Syrjälä <ville.syrjala at linux.intel.com>
> 
> All of the .queue_flip() callbacks duplicate the same code to pin the
> buffers and calculate the gtt_offset. Move that code to
> intel_crtc_page_flip(). In order to do that we must also move the ring
> selection logic there.
> 
> Signed-off-by: Ville Syrjälä <ville.syrjala at linux.intel.com>

I was a little uneasy about this given the fun-and-games we play with
ring selection and the historic issues we have had with bugs in
unpinning. However, this looks to be worth it, especially with the new
piece of common code,
Reviewed-by: Chris Wilson <chris at chris-wilson.co.uk>
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre