[Intel-gfx] [PATCH V4 3/6] drm/i915:Initialize the second BSD ring on BDW GT3 machine

Zhao Yakui yakui.zhao at intel.com
Fri Apr 25 03:13:44 CEST 2014


On Thu, 2014-04-24 at 09:21 -0600, Daniel Vetter wrote:
> On Thu, Apr 17, 2014 at 10:37:37AM +0800, Zhao Yakui wrote:
> > Based on the hardware spec, the BDW GT3 machine has two independent
> > BSD ring that can be used to dispatch the video commands.
> > So just initialize it.
> > 
> > V3->V4: Follow Imre's comment to do some minor updates. For example:
> > more comments are added to describe the semaphore between ring.
> > 
> > Reviewed-by: Imre Deak <imre.deak at intel.com>
> > Signed-off-by: Zhao Yakui <yakui.zhao at intel.com>
> > ---
> [snip]
> 
> > +/**
> > + * Initialize the second BSD ring for Broadwell GT3.
> > + * It is noted that this only exists on Broadwell GT3.
> > + */
> > +int intel_init_bsd2_ring_buffer(struct drm_device *dev)
> > +{
> > +	struct drm_i915_private *dev_priv = dev->dev_private;
> > +	struct intel_ring_buffer *ring = &dev_priv->ring[VCS2];
> > +
> > +	if ((INTEL_INFO(dev)->gen != 8) ) {
> 
> Checkpatch complained about the space here, I've fixed it up quickly.
> Running checkpatch before submitting patches is highly recommended so that
> we all nicely follow the official linux kernel Coding Style.

Thanks for the suggestion.
I will pay attention to this next time.

Thanks.
    Yakui

> 
> Cheers, Daniel





More information about the Intel-gfx mailing list