[Intel-gfx] [PATCH 1/3] lib: Export interval_tree

Daniel Vetter daniel at ffwll.ch
Fri Apr 25 16:17:27 CEST 2014


On Tue, Mar 18, 2014 at 09:56:12AM +0000, Chris Wilson wrote:
> On Mon, Mar 17, 2014 at 06:08:57AM -0700, Michel Lespinasse wrote:
> > On Mon, Mar 17, 2014 at 5:31 AM, David Woodhouse <dwmw2 at infradead.org> wrote:
> > > On Mon, 2014-03-17 at 12:21 +0000, Chris Wilson wrote:
> > >> +EXPORT_SYMBOL(interval_tree_insert);
> > >> +EXPORT_SYMBOL(interval_tree_remove);
> > >> +EXPORT_SYMBOL(interval_tree_iter_first);
> > >> +EXPORT_SYMBOL(interval_tree_iter_next);
> > >
> > > I'd prefer to see EXPORT_SYMBOL_GPL for this.
> > 
> > I'm fine with it either way. I think it would help if you stated the
> > reason for your preference though ?
> 
> Nobody objects?
> 
> How about
> 
> v3: Prefer EXPORT_SYMBOL_GPL for new library routines
> 
> as the reason in the changelog for amending the patch?

Frobbed _GPL onto the exports while applying and pulled into my
drm-intel-next queue for 3.16. Thanks for the patch and reviews.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch



More information about the Intel-gfx mailing list