[Intel-gfx] [PATCH] drm/i915: Avoid NULL ctx->obj dereference in debugfs/i915_context_info

Daniel Vetter daniel at ffwll.ch
Wed Apr 30 14:40:32 CEST 2014


On Wed, Apr 30, 2014 at 02:00:16PM +0300, Jani Nikula wrote:
> On Wed, 30 Apr 2014, Daniel Vetter <daniel at ffwll.ch> wrote:
> > On Wed, Apr 30, 2014 at 08:30:00AM +0100, Chris Wilson wrote:
> >> In commit 691e6415c891b8b2b082a120b896b443531c4d45
> >> Author: Chris Wilson <chris at chris-wilson.co.uk>
> >> Date:   Wed Apr 9 09:07:36 2014 +0100
> >> 
> >>     drm/i915: Always use kref tracking for all contexts.
> >> 
> >> we populated fake contexts on all platforms. These were identical to the
> >> full hardware context tracking structs, except for the ctx->obj used to
> >> store the hardware state. However, there remained one place where we
> >> assumed that if a context existed, it would have an object associated
> >> with it.
> >> 
> >> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=77717
> >> Testcase: igt/drv_suspend/debugfs-reader
> >> Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
> >
> > Queued for -next, thanks for the patch.
> 
> Why not -fixes? "drm/i915: Always use kref tracking for all contexts" is
> present in v3.15-rc2.

I guess we could merge it to -fixes, otoh this is for debugfs ... Dunno
whether we should throw this at grumpy Linus really.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch



More information about the Intel-gfx mailing list