[Intel-gfx] [PATCH] drm/i915: only hook up hpd pulse for DP setups.

Dave Airlie airlied at gmail.com
Sat Aug 2 00:16:10 CEST 2014


On 2 August 2014 07:38, Paulo Zanoni <przanoni at gmail.com> wrote:
> 2014-08-01 17:47 GMT-03:00 Dave Airlie <airlied at gmail.com>:
>> From: Dave Airlie <airlied at redhat.com>
>>
>> On HSW/BDW the VBT can tell us if we need to have DP support for a port,
>> if we don't have DP this caused an oops in the hpd handling.
>>
>> Don't hook up the DP hpd handling if we don't have a DP port.
>>
>> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=81856
>> Reported-by: Intel QA Team.
>> Signed-off-by: Dave Airlie <airlied at redhat.com>
>
> The patch looks correct, but AFAIK we didn't need it in the past, so I
> am curious about why is it needed now. What changed that caused the
> need for it?

Well the pulse handling is only new and I think we should have hit
this prior to MST, since hpd_pulse called intel_dp_check_link_status.

Prior to the pulse irq, intel_ddi check if the port was eDP or DP
before proceeding.

Dave



More information about the Intel-gfx mailing list