[Intel-gfx] [PATCH 5/7] drm/i915: Initialize the aliasing ppgtt as part of global gtt

Daniel Vetter daniel at ffwll.ch
Mon Aug 4 17:38:43 CEST 2014


On Fri, Aug 01, 2014 at 09:54:09AM +0000, Thierry, Michel wrote:
> > > @@ -1766,6 +1771,20 @@ int i915_gem_setup_global_gtt(struct
> > drm_device *dev,
> > >  	/* And finally clear the reserved guard page */
> > >  	ggtt_vm->clear_range(ggtt_vm, end - PAGE_SIZE, PAGE_SIZE, true);
> > >
> > > +	if (HAS_ALIASING_PPGTT(dev) && USES_FULL_PPGTT(dev)) {
> > 
> > Should that be !USES_FULL_PPGTT ?
> I think we need this for aliasing & full ppgtt (the global default ctx)...
> so it should be USES_PPGTT.

We want to setup the aliasing ppgtt _only_ when required, so we don't
actually need it for USES_FULL_PPGTT. So Ville's right here.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch



More information about the Intel-gfx mailing list