[Intel-gfx] [PATCH 03/12] Don't use GetScratchPixmapHeader for shadow pixmaps

[Eric Anholt]

Keith Packard <keithp at keithp.com> writes:

> Eric Anholt <eric at anholt.net> writes:
>
>> This change appears to be unrelated, and possibly harmful (if X has
>> dropped the last ref to the BO, but it's still the scanout buffer, a new
>> allocation would now reuse the BO and scribble on scanout until the next
>> modeset happens).
>
> Yeah, it's unrelated. intel_allocate_framebuffer calls disable_reuse, so
> there's no need to call it from these two other places. I'll split that
> change out into a separate patch with separate comment.
>
>> Unrelated whitespace.
>
> There are a bunch of whitespace fixups; should I pull those into a
> separate patch or just leave them scattered in the first patch to change
> a file?

One patch at the front is fine with me.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 818 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/intel-gfx/attachments/20140804/7a2d16f4/attachment.sig>