[Intel-gfx] [PATCH 0/6 v2] Add 180 degree primary and sprite rotation

Daniel Vetter daniel at ffwll.ch
Tue Aug 5 15:35:48 CEST 2014


On Tue, Aug 05, 2014 at 04:25:42PM +0300, Ville Syrjälä wrote:
> On Tue, Aug 05, 2014 at 11:26:51AM +0530, sonika.jindal at intel.com wrote:
> > From: Sonika Jindal <sonika.jindal at intel.com>
> > 
> > This patchset provides support for 0/180 degree hardare rotaion for primary and
> > sprite planes. The rotation property is now made global and is part of
> > drm_mode_config. It is attached to different planes.
> > 
> > v2: Moving the creation of property back to i915 (Ville) and resetting property
> > after disabling plane (Ville)
> 
> The series looks good to me.
> 
> For the patches not authored by me:
> Reviewed-by: Ville Syrjälä <ville.syrjala at linux.intel.com>
> 
> > 
> > Sonika Jindal (3):
> >   drm: Add rotation_property to mode_config
> >   drm/i915: Add 180 degree primary plane rotation support
> >   drm: Resetting rotation property

You've managed to cc exactly the wrong set of patches to dri-devel, namely
the i915 specific ones. You should have cc'ed just the ones touching core
drm (more if you feel like). Can you please fix that by resending?

I've pulled them into dinq for now meanwhile.

Thanks, Daniel

> 
> > Ville Syrjälä (3):
> >   drm/i915: Add 180 degree sprite rotation support
> >   drm/i915: Make intel_plane_restore() return an error
> >   drm/i915: Add rotation property for sprites
> > 
> >  drivers/gpu/drm/drm_fb_helper.c      |    9 ++-
> >  drivers/gpu/drm/i915/i915_reg.h      |    4 ++
> >  drivers/gpu/drm/i915/intel_display.c |  109 ++++++++++++++++++++++++++++++++--
> >  drivers/gpu/drm/i915/intel_drv.h     |    3 +-
> >  drivers/gpu/drm/i915/intel_pm.c      |    6 ++
> >  drivers/gpu/drm/i915/intel_sprite.c  |   93 ++++++++++++++++++++++++++---
> >  include/drm/drm_crtc.h               |    1 +
> >  7 files changed, 211 insertions(+), 14 deletions(-)
> > 
> > -- 
> > 1.7.10.4
> > 
> > _______________________________________________
> > Intel-gfx mailing list
> > Intel-gfx at lists.freedesktop.org
> > http://lists.freedesktop.org/mailman/listinfo/intel-gfx
> 
> -- 
> Ville Syrjälä
> Intel OTC
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch



More information about the Intel-gfx mailing list