[Intel-gfx] [PATCH] drm/i915: lock around link status and link training.

Dave Airlie airlied at gmail.com
Wed Aug 6 01:59:24 CEST 2014


On 6 August 2014 08:07, Daniel Vetter <daniel at ffwll.ch> wrote:
> On Tue, Aug 5, 2014 at 2:40 AM, Dave Airlie <airlied at gmail.com> wrote:
>> @@ -3502,10 +3505,13 @@ go_again:
>>  void
>>  intel_dp_check_link_status(struct intel_dp *intel_dp)
>>  {
>> +       struct drm_device *dev = intel_dp_to_dev(intel_dp);
>>         struct intel_encoder *intel_encoder = &dp_to_dig_port(intel_dp)->base;
>>         u8 sink_irq_vector;
>>         u8 link_status[DP_LINK_STATUS_SIZE];
>>
>> +       WARN_ON(!drm_modeset_is_locked(&dev->mode_config.connection_mutex));
>> +
>>         /* FIXME: This access isn't protected by any locks. */
>
> If you drop the FIXME here (since this patch address it) this is
>
> Reviewed-by: Daniel Vetter <daniel.vetter at ffwll.ch>
>
> I guess you'll pick this up directly to drm-next like that other mst
> fixes?

FIXME gone, and yes in -next now.

Hopefully that is all the QA fixes :-)

Dave.



More information about the Intel-gfx mailing list