[Intel-gfx] [PATCH] drm/i915: Fix secure dispatch with full ppgtt

Chris Wilson chris at chris-wilson.co.uk
Mon Aug 11 12:17:40 CEST 2014


On Mon, Aug 11, 2014 at 12:08:58PM +0200, Daniel Vetter wrote:
> Based upon a hunk from a patch from Chris Wilson, but augmented to:
> - Process the batch in the full ppgtt vm so that self-relocations
>   match again with userspace's expectations..
> - Add a comment why plain pin for the global gtt binding is safe at
>   that point.
> 
> v2: Drop local bind_vm variable (Chris).
> 
> Cc: Chris Wilson <chris at chris-wilson.co.uk>
> Cc: Ben Widawsky <benjamin.widawsky at intel.com>
> Signed-off-by: Daniel Vetter <daniel.vetter at ffwll.ch>

/me jaw drops

Oh nice, yes you are right that does fix the issue with the relocations
being in one address space whilst the exec needs to be done from gGTT.

Reviewed-by: Chris Wilson <chris at chris-wilson.co.uk>
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre



More information about the Intel-gfx mailing list