[Intel-gfx] [PATCH] drm/i915: WARN if module opt sanitization goes out of order

Daniel Vetter daniel.vetter at ffwll.ch
Mon Aug 11 15:59:52 CEST 2014


Depending upon one module option to be sanitized (through USES_PPGTT)
for the other is a bit too fragile for my taste. At least WARN about
this.

Cc: Ben Widawsky <ben at bwidawsk.net>
Cc: Damien Lespiau <damien.lespiau at intel.com>
Cc: Oscar Mateo <oscar.mateo at intel.com>
Signed-off-by: Daniel Vetter <daniel.vetter at ffwll.ch>
---
 drivers/gpu/drm/i915/intel_lrc.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/gpu/drm/i915/intel_lrc.c b/drivers/gpu/drm/i915/intel_lrc.c
index 21f7f1cce86e..44721292eb77 100644
--- a/drivers/gpu/drm/i915/intel_lrc.c
+++ b/drivers/gpu/drm/i915/intel_lrc.c
@@ -43,6 +43,8 @@
 
 int intel_sanitize_enable_execlists(struct drm_device *dev, int enable_execlists)
 {
+	WARN_ON(i915.enable_ppgtt == -1);
+
 	if (enable_execlists == 0)
 		return 0;
 
-- 
2.0.1




More information about the Intel-gfx mailing list