[Intel-gfx] [PATCH v2 1/5] drm/i915: take display port power domain in DP HPD handler

[Dave Airlie]

> Ville noticed that we can call ibx_digital_port_connected() which accesses
> the HW without holding any power well/runtime pm reference. Fix this by
> holding a display port power domain reference around the whole hpd_pulse
> handler.
>
> Signed-off-by: Imre Deak <imre.deak at intel.com>

Makes sense to me,

Reviewed-by: Dave Airlie <airlied at redhat.com>

> ---
>  drivers/gpu/drm/i915/intel_dp.c | 19 ++++++++++++++-----
>  1 file changed, 14 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
> index e5ada4f..0ebad42 100644
> --- a/drivers/gpu/drm/i915/intel_dp.c
> +++ b/drivers/gpu/drm/i915/intel_dp.c
> @@ -4037,9 +4037,12 @@ bool
>  intel_dp_hpd_pulse(struct intel_digital_port *intel_dig_port, bool long_hpd)
>  {
>         struct intel_dp *intel_dp = &intel_dig_port->dp;
> +       struct intel_encoder *intel_encoder = &intel_dig_port->base;
>         struct drm_device *dev = intel_dig_port->base.base.dev;
>         struct drm_i915_private *dev_priv = dev->dev_private;
> -       int ret;
> +       enum intel_display_power_domain power_domain;
> +       bool ret = true;
> +
>         if (intel_dig_port->base.type != INTEL_OUTPUT_EDP)
>                 intel_dig_port->base.type = INTEL_OUTPUT_DISPLAYPORT;
>
> @@ -4047,6 +4050,9 @@ intel_dp_hpd_pulse(struct intel_digital_port *intel_dig_port, bool long_hpd)
>                       port_name(intel_dig_port->port),
>                       long_hpd ? "long" : "short");
>
> +       power_domain = intel_display_port_power_domain(intel_encoder);
> +       intel_display_power_get(dev_priv, power_domain);
> +
>         if (long_hpd) {
>                 if (!ibx_digital_port_connected(dev_priv, intel_dig_port))
>                         goto mst_fail;
> @@ -4062,8 +4068,7 @@ intel_dp_hpd_pulse(struct intel_digital_port *intel_dig_port, bool long_hpd)
>
>         } else {
>                 if (intel_dp->is_mst) {
> -                       ret = intel_dp_check_mst_status(intel_dp);
> -                       if (ret == -EINVAL)
> +                       if (intel_dp_check_mst_status(intel_dp) == -EINVAL)
>                                 goto mst_fail;
>                 }
>
> @@ -4077,7 +4082,8 @@ intel_dp_hpd_pulse(struct intel_digital_port *intel_dig_port, bool long_hpd)
>                         drm_modeset_unlock(&dev->mode_config.connection_mutex);
>                 }
>         }
> -       return false;
> +       ret = false;
> +       goto put_power;
>  mst_fail:
>         /* if we were in MST mode, and device is not there get out of MST mode */
>         if (intel_dp->is_mst) {
> @@ -4085,7 +4091,10 @@ mst_fail:
>                 intel_dp->is_mst = false;
>                 drm_dp_mst_topology_mgr_set_mst(&intel_dp->mst_mgr, intel_dp->is_mst);
>         }
> -       return true;
> +put_power:
> +       intel_display_power_put(dev_priv, power_domain);
> +
> +       return ret;
>  }
>
>  /* Return which DP Port should be selected for Transcoder DP control */
> --
> 1.8.4
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx