[Intel-gfx] [PATCH] drm/i915: Track cursor changes as frontbuffer tracking flushes

Rodrigo Vivi rodrigo.vivi at gmail.com
Thu Aug 14 21:49:06 CEST 2014


Tested-by and Reviewed-by: Rodrigo Vivi <rodrigo.vivi at intel.com>


On Fri, Aug 8, 2014 at 11:27 AM, Daniel Vetter <daniel.vetter at ffwll.ch>
wrote:

> We treat other plane updates in the same fashion. Spotted because
> Rodrigo kept reporting a bug in the PSR code where the frontbuffer was
> eternally stuck with a dirty cursor bit set.
>
> The psr testcase should have caught this, but that i-g-t is kaputt.
> Rodrigo is signed up to fix that.
>
> Cc: Rodrigo Vivi <rodrigo.vivi at intel.com>
> Signed-off-by: Daniel Vetter <daniel.vetter at ffwll.ch>
> ---
>  drivers/gpu/drm/i915/intel_display.c | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/intel_display.c
> b/drivers/gpu/drm/i915/intel_display.c
> index fac7bdfe9ec8..91984710b841 100644
> --- a/drivers/gpu/drm/i915/intel_display.c
> +++ b/drivers/gpu/drm/i915/intel_display.c
> @@ -11677,6 +11677,10 @@ intel_cursor_plane_update(struct drm_plane
> *plane, struct drm_crtc *crtc,
>                 return intel_crtc_cursor_set_obj(crtc, obj, crtc_w,
> crtc_h);
>         } else {
>                 intel_crtc_update_cursor(crtc, visible);
> +
> +               intel_frontbuffer_flip(crtc->dev,
> +
>  INTEL_FRONTBUFFER_CURSOR(intel_crtc->pipe));
> +
>                 return 0;
>         }
>  }
> --
> 2.0.1
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
>



-- 
Rodrigo Vivi
Blog: http://blog.vivi.eng.br
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/intel-gfx/attachments/20140814/a8d71fff/attachment.html>


More information about the Intel-gfx mailing list