[Intel-gfx] [PATCH v2] drm/i915: Don't warn if we restore pm interrupts during reset

[Chris Wilson]

On Thu, Aug 14, 2014 at 05:45:59PM +0300, Ville Syrjälä wrote:
> On Thu, Aug 14, 2014 at 04:23:16PM +0200, Daniel Vetter wrote:
> > On Thu, Aug 14, 2014 at 03:46:43PM +0300, Mika Kuoppala wrote:
> > > We lost the software state tracking due to reset, so don't
> > > complain if it doesn't match.
> > 
> > This sounds more like gpu reset should be a bit more careful (even more
> > careful than we already are compared to earlier kernels) with making sure
> > the irq state is still sane after a reset?
> > 
> > Or what exactly is the failure mode here? The commit message lacks a bit
> > details in form of a nice text or even better: A testcase ;-)
> 
> Killing the hpd irq and gt_powersave junk from i915_reset() would be my
> suggestion here. I don't even know why the hpd stuff is still there, we
> removed all the other irq frobbery from there a while back. And last I
> looked gpu reset didn't affect the rc6/rps stuff either, though more
> testing should be done to make sure I didn't just imagine it.

I'd like a call to intel_mark_idle() since we are resetting the GPU
activity tracker. That is meant to dtrt with all the powersave tracking
as well. (Well if someone would just review some patches it might dtrt!)
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre