[Intel-gfx] [PATCH 1/2] drm/i915/bdw: Apply workarounds using the golden render state

Ville Syrjälä ville.syrjala at linux.intel.com
Wed Aug 20 16:52:54 CEST 2014


On Wed, Aug 20, 2014 at 03:19:17PM +0100, Arun Siluvery wrote:
> Workarounds for bdw are currently applied in init_clock_gating() but they
> are lost following a gpu reset. Some of the WA registers are part of register
> state context and they are restored with every context switch so initializing
> them in golden render state ensures that they are applied even when we start
> with an uninitialized context or during hw initlialization followed by a reset.
> 
> v2: Add comments corresponding to WAs in golden render state (Chris).
> 
> The generation of render state is not a straighforward process, it would
> be ideal to augment WA values from during the setup state as opposed to
> using a tool but that would be a follow up patch.

I'd still prefer just emitting the LRIs from code rather tha mucking
about with null batch. Less hoops to jump through when adding a new w/a.

-- 
Ville Syrjälä
Intel OTC



More information about the Intel-gfx mailing list