[Intel-gfx] [PATCH v2] drm/i915: Handle i915_ppgtt_put correctly

Daniel Vetter daniel at ffwll.ch
Tue Aug 26 14:39:15 CEST 2014


On Tue, Aug 19, 2014 at 03:49:41PM +0100, Michel Thierry wrote:
> Unfortunately, the gem_obj/vma relationship is not symmetrical; a gem_obj
> can look up for the same vma more than once (where the ppgtt refcount is
> incremented), but will free the vma only once (i915_gem_free_object).
> 
> This difference in refcount get/put means that the ppgtt is not removed
> after the context and vma are destroyed, because sometimes the refcount
> will never go back to zero.
> 
> v2: Just move the ppgtt refcount into vma_create.
> 
> OTC-Jira: VIZ-3719
> Signed-off-by: Michel Thierry <michel.thierry at intel.com>

Queued for -next, thanks for the patch.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch



More information about the Intel-gfx mailing list