[Intel-gfx] [PATCH] drm/i915/bdw: Add BDW support in the i915 debugfs entry

[Daniel Vetter]

On Wed, Aug 20, 2014 at 12:04:31PM -0700, vedang.patel at intel.com wrote:
> From: Vedang Patel <vedang.patel at intel.com>
> 
> The patch introduces fixes for the debugfs attributes emitted by
> the i915 driver for GEN8. Currently, it is not emitting the correct
>  attributes which include the status of RC6 states.
> 
> Change-Id: Ib2068a0cac9a5wq3f228e547fa1a097ad369d242df
> Signed-off-by: Vedang Patel <vedang.patel at intel.com>
> ---
>  drivers/gpu/drm/i915/i915_debugfs.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c
> index 850fa59..2296a22 100644
> --- a/drivers/gpu/drm/i915/i915_debugfs.c
> +++ b/drivers/gpu/drm/i915/i915_debugfs.c
> @@ -1329,7 +1329,7 @@ static int i915_drpc_info(struct seq_file *m, void *unused)
>  
>  	if (IS_VALLEYVIEW(dev))
>  		return vlv_drpc_info(m);
> -	else if (IS_GEN6(dev) || IS_GEN7(dev))
> +	else if (IS_GEN6(dev) || IS_GEN7(dev) || IS_GEN8(dev))

I think an INTEL_INFO(dev)->gen >= 6 check here looks better and is more
future proof. Can you please update the patch accordingly?

Thanks, Daniel

>  		return gen6_drpc_info(m);
>  	else
>  		return ironlake_drpc_info(m);
> -- 
> 1.7.9.5
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch