[Intel-gfx] [PATCH 1/2] drm/i915/bdw: Apply workarounds in render ring init function

[Chris Wilson]

On Tue, Aug 26, 2014 at 05:37:05PM +0300, Ville Syrjälä wrote:
> On Tue, Aug 26, 2014 at 02:44:50PM +0100, Arun Siluvery wrote:
> > For BDW workarounds are currently initialized in init_clock_gating() but
> > they are lost during reset, suspend/resume etc; this patch moves the WAs
> > that are part of register state context to render ring init fn otherwise
> > default context ends up with incorrect values as they don't get initialized
> > until init_clock_gating fn.

I am dubious here. How does the default context end up with incorrect
values if the registers are loaded afterwards and the default context is
*never* restored from memory? Could you explain how this exactly fails?
Could you explain why only gen8 is affected?
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre