[Intel-gfx] [PATCH] drm/i915/ddi: use struct for ddi buf translation tables

Daniel Vetter daniel at ffwll.ch
Wed Aug 27 15:55:17 CEST 2014


On Wed, Aug 27, 2014 at 02:47:05PM +0100, Damien Lespiau wrote:
> On Wed, Aug 27, 2014 at 04:27:30PM +0300, Jani Nikula wrote:
> >  	/* Entry 9 is for HDMI: */
> >  	for (i = 0; i < 2; i++) {
> > -		I915_WRITE(reg, ddi_translations_hdmi[hdmi_level * 2 + i]);
> > +		I915_WRITE(reg, ddi_translations_hdmi[hdmi_level + i].trans1);
> > +		reg += 4;
> > +		I915_WRITE(reg, ddi_translations_hdmi[hdmi_level + i].trans2);
> >  		reg += 4;
> >  	}
> 
> It seems we're writing a bit too many times there now (we don't need the
> the for() loop anymore).

It totally never happend ;-)

Thanks, Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch



More information about the Intel-gfx mailing list