[Intel-gfx] [PATCH 2/2] drm/i915: s, fb->bits_per_pixel/8, pixel_size, in primary plane code

[Chris Wilson]

On Wed, Aug 27, 2014 at 04:51:22PM +0300, ville.syrjala at linux.intel.com wrote:
> From: Ville Syrjälä <ville.syrjala at linux.intel.com>
> 
> Use the pixel_size we got from drm_format_plane_cpp() instead of
> fb->bits_per_pixel/8 when computing the primary plane page/linear
> offsets. Avoids a few divs and makes the code more future proof
> against funky pixel formats where bits_per_pixel isn't well defined.
> This is what we already did in the sprite code.

A little bit of software archeology revealed

commit ca320ac456099c29290568353d924157e626ede9
Author: Chris Wilson <chris at chris-wilson.co.uk>
Date:   Wed Dec 19 12:14:22 2012 +0000

    drm/i915: Use pixel size for computing linear offsets into a sprite

I misremembered that as an oops in the primary plane when using
pixel_size.  That concern addressed,
Reviewed-by: Chris Wilson <chris at chris-wilson.co.uk>
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre