[Intel-gfx] [PATCH] drm/i915/ilk: special case enabling of PCU_EVENT interrupt

Jesse Barnes jbarnes at virtuousgeek.org
Wed Aug 27 23:36:21 CEST 2014


On Wed, 27 Aug 2014 23:33:05 +0200
Daniel Vetter <daniel at ffwll.ch> wrote:

> On Wed, Aug 27, 2014 at 9:59 PM, Jesse Barnes <jbarnes at virtuousgeek.org> wrote:
> > Yi, can you get this one run through testing on multiple platforms?  We
> > just want to make sure there's not some path we missed that's gonna
> > spew a warning with this change.
> 
> I think that amount of testing is totally out of balance to keep a
> rather tiny warninig alive in the driver load code. The major use for
> the pm._irqs_disabled is to catch runtime pm bugs where code uses
> changes irq settings while the chip is off. That part will still be
> 100% effective with Jesse's patch.
> 
> So I recommended that we instead merge Jesses patch instead of mine
> for -fixes. Jesse's patch has my r-b fwiw.

Either is fine with me.  Maybe you could cc the PRTS and see if it
gives you results!

-- 
Jesse Barnes, Intel Open Source Technology Center



More information about the Intel-gfx mailing list