[Intel-gfx] [PATCH] igt/gem_workarounds: igt to test workaround registers

Damien Lespiau damien.lespiau at intel.com
Sat Aug 30 17:22:04 CEST 2014


On Tue, Aug 26, 2014 at 02:50:28PM +0100, Arun Siluvery wrote:
> +	igt_subtest("check-workaround-data-after-suspend-resume") {
> +		if (IS_BROADWELL(devid))
> +			check_workarounds(SUSPEND_RESUME, num_wa_regs);
> +		else
> +			igt_skip_on("No Workaround table available!!\n");
> +	}

This kind of check needs updating for each platform. That generates a
lot of "stupid" work. And indeed, it's already out of date (CHV).

We should be able to use some information from the debugfs file directly
to do the right thing. With your current format for the debugfs file, I
don't think we need a platform test at all. platforms that don't have a
list will just expose: "Workarounds applied: 0\n" and we can happily
pass the test.

-- 
Damien



More information about the Intel-gfx mailing list