[Intel-gfx] [PATCH 0/9] BYT DSI Dual Link Support

[Jani Nikula]

On Sat, 29 Nov 2014, Gaurav K Singh <gaurav.k.singh at intel.com> wrote:
> Hi,
>
> These set of patches build on top of the existing DSI Video mode support to
> enable dual link MIPI panels with high resolutions. These patches have been
> tested on a 25x16 panel and works well.

Good job, it's starting to look good. Please go ahead and start
addressing the review comments I made. I've glanced through all the
patches, but I'll still have a more in-depth look.

Thanks,
Jani.


>
> v2: Commit message added to all patches. All review comments of Jani, Nikula
> have been addressed in the second version of patches.
>
> v3: for_each_dsi_port macro used instead of for loop for dual link support
>
> Regards
> Gaurav
>
> Gaurav K Singh (9):
>   drm/i915: New functions added for enabling & disabling MIPI Port Ctrl
>     reg
>   drm/i915: Added port as parameter to the functions which does
>     read/write of DSI Controller
>   drm/i915: Add support for port enable/disable for dual link
>     configuration
>   drm/i915: Pixel Clock changes for DSI dual link
>   drm/i915: Dual link needs Shutdown and Turn on packet for both ports
>   drm/i915: Enable DSI PLL for both DSI0 and DSI1 in case of dual link
>   drm/i915: MIPI Timings related changes for dual link
>   drm/i915: Update the DSI disable path to support dual link panel
>     disabling
>   drm/i915: Update the DSI enable path to support dual link panel
>     enabling
>
>  drivers/gpu/drm/i915/i915_reg.h            |    5 +
>  drivers/gpu/drm/i915/intel_bios.h          |    3 +-
>  drivers/gpu/drm/i915/intel_dsi.c           |  415 +++++++++++++++++-----------
>  drivers/gpu/drm/i915/intel_dsi.h           |    7 +
>  drivers/gpu/drm/i915/intel_dsi_cmd.c       |  101 ++++---
>  drivers/gpu/drm/i915/intel_dsi_cmd.h       |   46 +--
>  drivers/gpu/drm/i915/intel_dsi_panel_vbt.c |   49 +++-
>  drivers/gpu/drm/i915/intel_dsi_pll.c       |    9 +-
>  8 files changed, 383 insertions(+), 252 deletions(-)
>
> -- 
> 1.7.9.5
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Jani Nikula, Intel Open Source Technology Center